debug: evaluate all refs to allow multi-platform debugging #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
commented
May 10, 2023
Comment on lines
-209
to
-227
| imgRef, err := c.Solve(ctx, gateway.SolveRequest{ | ||
| Definition: def.ToPB(), | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
@ktock I'm not quite sure if I'm missing something here - I don't think this second evaluation is necessary?
Collaborator
There was a problem hiding this comment.
Yes, I think it's not necessary.
ktock
approved these changes
May 10, 2023
tonistiigi
approved these changes
May 11, 2023
Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
debug-multi-platform
branch
from
00a2fc8 to
45fccef
Compare
crazy-max
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes #1640 (comment).
This is a bit of a hack for now, but this allows us to debug multi-platform results.
On a success, the first entry in the result's platform metadata key is selected, on a failure, the platform which encountered an error is selected.